DM-54463: Adapt new collection naming in Prompt Processing#375
DM-54463: Adapt new collection naming in Prompt Processing#375
Conversation
A number of changes at the shared butler repos made the script out of date: - old raw data were zipped and moved out of the embargo storage - storage location of template coadds were moved and collections were changed
isullivan
left a comment
isullivan
left a comment
There was a problem hiding this comment.
There are a few additional places in this repo that return the value from get_day_obs, and those should have their type updated from str to int.
E.g.
prompt_processing/python/initializer/write_init_outputs.py
Lines 150 to 153 in 75bd62c
|
|
||
|
|
||
| def get_day_obs(time: astropy.time.Time) -> str: | ||
| """Convert a timestamp into a day-obs string. |
There was a problem hiding this comment.
The type annotation should be -> int
There was a problem hiding this comment.
Thanks so much for catching the missing converts!
They are now corrected.
There was a problem hiding this comment.
I don't think changing the type to int was necessary or appropriate -- it was always intended as an identifier, and it's essentially forcing you to convert back to string to use it. But I suppose the damage is done...
There was a problem hiding this comment.
It wasn't necessary but I thought it would be appropriate. Sorry! I can change it back too.
hsinfang
force-pushed
the
tickets/DM-54463
branch
from
17d457e to
37c4bea
Compare
The new LSSTCam/calib collection at the production repo has gain_correction datasets.
In butler, day_obs is an integer in YYYYMMDD format, versus day_obs in this repo being a string YYYY-MM-DD. This change aligns day_obs usage with butler.
hsinfang
force-pushed
the
tickets/DM-54463
branch
from
00363bc to
abd49a4
Compare
|
Merging this and expecting it to be included in tomorrow's release for deployment tomorrow. Daytime AP team has been informed and DM-54464 is ready for Daytime AP. |
3 participants
This PR can only be merged if