DM-53734: Patch redis connection for handler tests#304
Merged
ugyballoons merged 2 commits intodevelopfrom Mar 4, 2026
Merged
Conversation
ugyballoons
force-pushed
the
tickets/DM-53734
branch
from
0ebd166 to
41d58b6
Compare
sebastian-aranda
approved these changes
Mar 4, 2026
Collaborator
sebastian-aranda
left a comment
sebastian-aranda
left a comment
There was a problem hiding this comment.
Looks good to me 👍 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although not breaking the tests during CI, this patch prevents unwanted errors from the app's lifespan context manager trying to close a Redis connection that never existed.
Update The attempted Redis connection is now breaking tests during CI.