Skip to content

DM-42201: Add flat core analysis tools pipeline#61

Open
Alex-Broughton wants to merge 1 commit intomainfrom
tickets/DM-42201
Open

DM-42201: Add flat core analysis tools pipeline#61
Alex-Broughton wants to merge 1 commit intomainfrom
tickets/DM-42201

Conversation

@Alex-Broughton
Copy link
Copy Markdown
Contributor

No description provided.

@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-42201 branch 3 times, most recently from 6e244df to e4dac0a Compare December 16, 2024 21:09
Comment thread python/lsst/cp/verify/mergeResults.py Outdated
Comment thread python/lsst/cp/verify/mergeResults.py
@czwa
Copy link
Copy Markdown
Collaborator

czwa commented Dec 16, 2024

This slipped my mind, but to add to this: If you add these new data products to python/lsst/cp/verify/configs/report.yaml, they will automatically be added to the cpv reports. The dataset_type_name is the key to the middle level dict, and should be (based on the analysis_tools changes) look like cpFlatDetMergeCore_flatTestsByDate_CalibAmpScatterTool using the outputName, the "test name" set under the atools header, and the output type.

@czwa
Copy link
Copy Markdown
Collaborator

czwa commented Dec 16, 2024

Sorry, cpFlatDetMergeCore_flatTestsByDate_GridPlot, I think is the right thing.

@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-42201 branch 2 times, most recently from 7945d88 to d6876fb Compare January 6, 2025 23:39
@czwa
Copy link
Copy Markdown
Collaborator

czwa commented Jan 17, 2025

This needs rebasing, which will hopefully get the gitignore update that will cause python/lsst_cp_verify.dist-info/METADATA to be ignored. If not, it should be removed from git manually. Otherwise, I'm happy here.

@timj
Copy link
Copy Markdown
Member

timj commented Jan 17, 2025

Rebasing won't cause the .dist-info to disappear -- the git ignore file does nothing after the fact. The commit that added it will have to be cleaned up.

@Alex-Broughton
Copy link
Copy Markdown
Contributor Author

Will do; will push my updated local branch when I finish fixing another ci_cpp error. Thanks for pointing it out

@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-42201 branch 4 times, most recently from d6fd79c to 760c39a Compare January 28, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants