DM-54599: validateDominantDbs() is called more frequently than seems necessary #1017
Merged
iagaponenko merged 1 commit intomainfrom Apr 9, 2026
Merged
DM-54599: validateDominantDbs() is called more frequently than seems necessary #1017iagaponenko merged 1 commit intomainfrom
iagaponenko merged 1 commit intomainfrom
Conversation
MAde the validator a private method of the QuerySession class. Eliminated all other calls to the validator. Adjusted unit tests to skip the validatons since this operation requires non-trivial CSS.
jgates108
approved these changes
Apr 9, 2026
Contributor
jgates108
left a comment
jgates108
left a comment
There was a problem hiding this comment.
That looks like the correct way to handle that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR addresses a design problem of the original implementation. The new implementation: