Open
Conversation
The eliminated code appears to be some left over experiment that was never finished, nor it matured into any reasonable idea. Another problem with the removed code was that it was making the package qana dependent on the Qserv frontend. This was not right from the dependency management standpoint.
This member has no actual effect on the query processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three commits in this PR:
Remove
queryDistributionTestVerfrom modulesczarandcconfigqanadirectly dependent on the Qserv frontend moduleczar. This was not right from the dependency management standpoint.Remove
QuerySession.h: int _isFinalThis member has no actual effect on the query processing
Remove unnecessary mutex locking from:
The current query creation code is thread-safe after migrating the CSS database connector to the thread-safe implementation.
A few notes:
mysql-proxyfrontend due to another lock within the proxy that serializes query submission.httpfrontend since it doesn’t have any additional locks