security: consolidated medium-severity remediation#3
Merged
Conversation
Force-override js-yaml to patched within-major versions to close out the three open MEDIUM Dependabot alerts (GHSA-h67p-54hq-rp68, quadratic-complexity DoS in merge-key handling): - root: js-yaml ^4.1.0 (eslint/@eslint/eslintrc) 4.1.1 -> 4.2.0 (alert #8) - root: js-yaml ^3.13.1 (@istanbuljs/load-nyc-config) 3.14.2 -> 3.15.0 (alert #7) - mcp: js-yaml ^3.13.1 (@istanbuljs/load-nyc-config) 3.14.2 -> 3.15.0 (alert #6) All dev-scoped transitive; scoped overrides keep the 3.x and 4.x lines on their own majors (no forced major bump). Lockfiles regenerated; lint, tests, coverage, MCP build and bundle-size gate all pass locally.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8313e91. Configure here.
| "overrides": { | ||
| "@babel/core": "^7.29.6" | ||
| "@babel/core": "^7.29.6", | ||
| "js-yaml@^4.1.0": "4.2.0", |
There was a problem hiding this comment.
Incomplete js-yaml security pin
Medium Severity
The new js-yaml@^4.1.0 override pins 4.2.0, which fixes GHSA-h67p-54hq-rp68 but remains in the affected range for high-severity GHSA-52cp-r559-cp3m (fixed in 4.3.0). The exact pin also blocks npm from resolving the patched 4.3.0 release that has been available since late June.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 8313e91. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Closes out all three open MEDIUM Dependabot alerts in this repo — all
js-yaml,advisory GHSA-h67p-54hq-rp68 (quadratic-complexity DoS in merge-key handling via
repeated aliases). All are dev-scoped, transitive dependencies.
Fixed via scoped npm
overridesthat pin eachjs-yamlline to the patched versionwithin its existing major (no forced major-version bumps):
^4.1.0^3.13.1^3.13.1Scoped overrides keep the 3.x and 4.x lines on their own majors — the 3.x coverage
tooling is unaffected by the 4.x API.
Verification (local)
npm ci,npm run lint,npm test -- --coverage(248 tests),check-coverage.mjs— all passnpm ci,npm test(83 tests),npm run build,check-bundle-size.mjs— all passOnly dependency manifests + lockfiles changed. CI is expected to be green.
Note
Low Risk
Manifest and lockfile-only changes for dev-scoped transitive dependencies; no runtime or application code paths change.
Overview
Addresses GHSA-h67p-54hq-rp68 (DoS in
js-yamlmerge-key handling) by pinning transitive devjs-yamlinstalls through scoped npmoverrides, without crossing major versions.The root
package.jsonnow forcesjs-yaml@^4.1.0→ 4.2.0 (eslint /@eslint/eslintrc) andjs-yaml@^3.13.1→ 3.15.0 (@istanbuljs/load-nyc-config).mcp/lua-platformadds the same 3.15.0 override for its Jest/coverage 3.x tree. Lockfiles only reflect the bumpedjs-yamlversions and metadata.Reviewed by Cursor Bugbot for commit 8313e91. Bugbot is set up for automated code reviews on this repo. Configure here.