refactor: Rename lua* modules to luna* and introduce new luna m…#423
Closed
iammuntazirali wants to merge 1 commit intoluainkernel:masterfrom
Closed
refactor: Rename lua* modules to luna* and introduce new luna m…#423iammuntazirali wants to merge 1 commit intoluainkernel:masterfrom
lua* modules to luna* and introduce new luna m…#423iammuntazirali wants to merge 1 commit intoluainkernel:masterfrom
Conversation
…odules for XDP, RCU, and other functionalities.
Collaborator
|
Is there a reason for renaming these? I looks quite a big change if it is just to help You could just generate different output .ko files names by changing |
Contributor
|
It seems that you have removed and added the files instead of just renaming it on git.. |
Contributor
Yeah.. the issue was meant to discuss it before doing it.. I was expecting to have some discussion on pros and cons first.. |
Contributor
|
Btw, @iammuntazirali, did you test it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #414: Rename Lunatik Bindings – Walkthrough
Summary
Renamed all Lunatik binding files from
lua<libname>.ctoluna<libname>.cto make it easier to identify loaded modules usinglsmod | grep luna.Changes Made
Files Renamed (31 total)
lib/ directory – 25 C source files
Build System Updates
Updated all binding module references from
lib/lua*.otolib/luna*.oUpdated
usr/lib/xtable/Makefileto referencelunaxt.cInternal Header References (16 updates)
Updated
#includedirectives in affected C files:lunacrypto.h: lunacrypto_aead.c, lunacrypto_shash.c, lunacrypto_skcipher.c, lunacrypto_comp.c, lunacrypto_rng.c
lunadata.h: lunahid.c, lunaxdp.c, lunaxtable.c, lunanetfilter.c, lunadata.c
lunarcu.h: lunaxdp.c, lunaxtable.c, lunarcu.c
lunanetfilter.h: lunaxtable.c
lunaxtable.h: lunaxtable.c
Verification Results
✓ 25
luna*.cfiles inlib/✓ 5
luna*.hfiles inlib/✓ 1
lunaxt.cinusr/lib/xtable/✓ No remaining
lua*.corlua*.hbinding files✓ No broken references in the build system