Serverlist enhancements#11342
Closed
ShadowNinja wants to merge 2 commits intoluanti-org:masterfrom
Closed
Conversation
sfan5
reviewed
Jun 13, 2021
Contributor
|
Closing as no response in a long time. Feel free to reopen |
85b09c7 to
a670a83
Compare
Contributor
Author
|
One change to HTTP Fetch that would be visible to the Lua API is that HTTP responses with a 400+ code doesn't cause |
Closed
This is useful for keeping track of worlds even if they change addresses.
a670a83 to
4f08916
Compare
Contributor
|
What remains to be done? |
Member
|
Probably ready, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two enhancements for the server list:
How to test
Change
src/serverlist.cppso that it sends invalid JSON, enable announce, and start a server.