Skip to content

Add mDNS dep and handle IPv4-only mDNS addr #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luar123 merged 2 commits into from
Mar 4, 2026
Merged

Add mDNS dep and handle IPv4-only mDNS addr #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d12e8c7
Add mDNS dep and handle IPv4-only mDNS addr
jb1228 Mar 2, 2026
35c7c89
Update components/snapclient/connection_handler.c
luar123 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/snapclient/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
idf_component_register(SRCS "snapclient_helper.c" "snapclient.c" "connection_handler.c"
INCLUDE_DIRS "include"

PRIV_REQUIRES esp_timer opus flac lightsnapcast
PRIV_REQUIRES esp_timer mdns opus flac lightsnapcast
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mdns is now listed in PRIV_REQUIRES unconditionally, but this component already adds it conditionally via idf_component_optional_requires(PRIVATE mdns) under if(CONFIG_SNAPSERVER_USE_MDNS). Keeping the dependency unconditional (and duplicated) will build/link the mdns component even when mDNS is disabled. Consider removing mdns from PRIV_REQUIRES and relying on the existing conditional idf_component_optional_requires, or otherwise make the dependency consistently conditional in one place.

Suggested change
PRIV_REQUIRES esp_timer mdns opus flac lightsnapcast
PRIV_REQUIRES esp_timer opus flac lightsnapcast

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Owner

@luar123 luar123 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why it is not working without this.

)

if(CONFIG_USE_DSP_PROCESSOR)
Expand Down
4 changes: 4 additions & 0 deletions components/snapclient/connection_handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,11 @@ void setup_network(esp_netif_t** netif) {
continue;
}

#if CONFIG_LWIP_IPV4 && !CONFIG_LWIP_IPV6
remote_ip.addr = re->addr->addr.u_addr.ip4.addr;
#else
ip_addr_copy(remote_ip, re->addr->addr);
#endif
remotePort = r->port;

mdns_query_results_free(r);
Expand Down