fix: prevent caching of non-200 response status codes in GZip middleware#174
Open
vschaefer wants to merge 1 commit intointegrationfrom
Open
fix: prevent caching of non-200 response status codes in GZip middleware#174vschaefer wants to merge 1 commit intointegrationfrom
vschaefer wants to merge 1 commit intointegrationfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR prevents caching of responses with non-200 status codes in the GZip middleware.
- Added a check on the response status code before caching
- Added a log statement when the response is not cached due to its status code
Comments suppressed due to low confidence (1)
src/server/middlewares/cacheGZipMiddleware.js:47
- [nitpick] Consider replacing console.log with a dedicated logging mechanism suitable for production environments to ensure proper log management.
console.log('Response status code is not 200, not caching');
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.