Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .jules/janitor.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
- 2026-01-20: Extract complex, self-contained logic blocks from main handlers into helper functions.
- 2026-01-26: Separate configuration data (like lists of magic strings) from business logic.
- 2025-02-18: Remove redundant tests that validate copy-pasted logic instead of the actual function.
- 2025-02-24: Use %q in logs for untrusted input to prevent log injection.
Comment on lines 3 to +6
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve the readability and maintainability of this journal, consider keeping the entries sorted by date in descending order (most recent first).

Suggested change
- 2026-01-20: Extract complex, self-contained logic blocks from main handlers into helper functions.
- 2026-01-26: Separate configuration data (like lists of magic strings) from business logic.
- 2025-02-18: Remove redundant tests that validate copy-pasted logic instead of the actual function.
- 2025-02-24: Use %q in logs for untrusted input to prevent log injection.
- 2026-01-26: Separate configuration data (like lists of magic strings) from business logic.
- 2026-01-20: Extract complex, self-contained logic blocks from main handlers into helper functions.
- 2025-02-24: Use %q in logs for untrusted input to prevent log injection.
- 2025-02-18: Remove redundant tests that validate copy-pasted logic instead of the actual function.

2 changes: 1 addition & 1 deletion api/index.go
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ func handler(w http.ResponseWriter, r *http.Request) {
rawLink := reconstructTargetURL(r)

format := getFormat(r)
log.Printf("request: %s %s", format, rawLink)
log.Printf("request: %q %q", format, rawLink)

link, err := normalizeAndValidateURL(rawLink)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion mise.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,5 @@ run = "echo 'No codegen tasks'"
description = "Run code generation"

[tasks.ci]
depends = ["install", "lint", "test"]
depends = ["lint", "test"]
description = "Run CI pipeline"