fix(engine/v2): symmetrische archetype mapping + gebalanceerde occasion bias#36
Open
lucavandee wants to merge 2 commits into
Open
fix(engine/v2): symmetrische archetype mapping + gebalanceerde occasion bias#36lucavandee wants to merge 2 commits into
lucavandee wants to merge 2 commits into
Conversation
…ion bias QUIZ_STYLE_TO_ARCHETYPE: - classic: 1.0 CLASSIC (was 0.7/0.2/0.1 verdeeld over CLASSIC/BUSINESS/MINIMALIST) - smart-casual: 0.7 SC + 0.3 CLASSIC (was pure 1.0 SC) OCCASION_ARCHETYPE_BIAS: - work: BUSINESS 0.25→0.15, CLASSIC 0.2→0.25 (minder aggressieve business-push) - casual: + AVANT_GARDE 0.1, + STREETWEAR 0.1 (meer variatie in casual) - date: + AVANT_GARDE 0.1 (ruimte voor expressievere date-looks) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Minimalisten die work als occasion kiezen kregen nog steeds een volledige BUSINESS push (+0.15) op hun profiel. Dat trok hun primary richting BUSINESS terwijl hun goals expliciet minimalistisch zijn. applyOccasionBias accepteert nu optioneel goals. Wanneer de user goals=minimal heeft en occ=work, wordt alleen de BUSINESS-component van de work-bias gehalveerd (0.15 → 0.075). Andere componenten (CLASSIC, SMART_CASUAL, MINIMALIST) blijven volledig staan. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
✅ Deploy Preview for fitfiai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twee structurele problemen uit de engine-audit opgelost in
src/engine/v2/buildProfile.ts.1. Symmetrische
QUIZ_STYLE_TO_ARCHETYPEmappingclassic→ pure{ CLASSIC: 1.0 }(was verdeeld 0.7/0.2/0.1 over CLASSIC/BUSINESS/MINIMALIST)smart-casual→{ SMART_CASUAL: 0.7, CLASSIC: 0.3 }(was pure 1.0)classic + smart-casualkiest krijgt nu CLASSIC als primary (was SMART_CASUAL door asymmetrie).2. Gebalanceerde
OCCASION_ARCHETYPE_BIASwork:BUSINESS0.25 → 0.15,CLASSIC0.2 → 0.25 (minder agressieve business-push)casual:+ AVANT_GARDE 0.1,+ STREETWEAR 0.1(meer variatie)date:+ AVANT_GARDE 0.1(ruimte voor expressievere date-looks)casual+date.3. Minimalisten beschermen tegen work-bias
Wanneer
goalsde waardeminimalbevat énocc === 'work', wordt alleen de BUSINESS-component van de work-bias gehalveerd (0.15 → 0.075). Andere componenten (CLASSIC, SMART_CASUAL, MINIMALIST) blijven volledig staan. Voorkomt dat minimalisten met een werkprofiel richting BUSINESS getrokken worden.Test plan
classic + smart-casual→ primary = CLASSICavant-garde + casual→ AVANT_GARDE blijft in top-2 na occasion-biasgoals=minimal + occasions=[work]→ primary blijft MINIMALIST-georiënteerd, geen BUSINESS-dominantiegoals=[]+occasions=[work]→ gedrag ongewijzigd t.o.v. f2230c9 (backwards-compat)npm run buildslaagt🤖 Generated with Claude Code