Skip to content

fix(engine/v2): relax formality-spread penalty for SMART_CASUAL and AVANT_GARDE #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucavandee wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(engine/v2): relax formality-spread penalty for SMART_CASUAL and AVANT_GARDE #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2230c9
fix(engine/v2): symmetrische archetype mapping en gebalanceerde occas…
Apr 18, 2026
bc7d9a8
fix(engine/v2): relax formality-spread penalty for SMART_CASUAL and A…
Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/engine/v2/buildProfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ import type {

const QUIZ_STYLE_TO_ARCHETYPE: Record<string, ArchetypeWeights> = {
minimalist: { MINIMALIST: 1.0 },
classic: { CLASSIC: 0.7, BUSINESS: 0.2, MINIMALIST: 0.1 },
classic: { CLASSIC: 1.0 },
streetwear: { STREETWEAR: 1.0 },
'smart-casual': { SMART_CASUAL: 1.0 },
smart_casual: { SMART_CASUAL: 1.0 },
'smart-casual': { SMART_CASUAL: 0.7, CLASSIC: 0.3 },
smart_casual: { SMART_CASUAL: 0.7, CLASSIC: 0.3 },
athletic: { ATHLETIC: 1.0 },
sporty: { ATHLETIC: 1.0 },
rugged: { SMART_CASUAL: 0.5, STREETWEAR: 0.5 },
Expand Down Expand Up @@ -87,10 +87,10 @@ const DEFAULT_ARCHETYPES: ArchetypeWeights = {
};

const OCCASION_ARCHETYPE_BIAS: Record<OccasionKey, ArchetypeWeights> = {
work: { BUSINESS: 0.25, CLASSIC: 0.2, SMART_CASUAL: 0.15, MINIMALIST: 0.1 },
work: { BUSINESS: 0.15, CLASSIC: 0.25, SMART_CASUAL: 0.15, MINIMALIST: 0.1 },
formal: { BUSINESS: 0.4, CLASSIC: 0.2, MINIMALIST: 0.05 },
casual: { SMART_CASUAL: 0.2, CLASSIC: 0.1 },
date: { CLASSIC: 0.15, SMART_CASUAL: 0.15, MINIMALIST: 0.1 },
casual: { SMART_CASUAL: 0.2, CLASSIC: 0.1, AVANT_GARDE: 0.1, STREETWEAR: 0.1 },
date: { CLASSIC: 0.15, SMART_CASUAL: 0.15, MINIMALIST: 0.1, AVANT_GARDE: 0.1 },
travel: { SMART_CASUAL: 0.2, MINIMALIST: 0.15 },
sport: { ATHLETIC: 0.5 },
};
Expand Down
55 changes: 49 additions & 6 deletions src/engine/v2/coherence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,49 @@ export interface CoherenceScores {
reasons: string[];
}

export function evaluateCoherence(products: ScoredProduct[]): CoherenceScores {
interface FormalityThresholds {
hardPenalty: number;
midPenalty: number;
softPenalty: number;
mismatchTag: number;
coherentTag: number;
}

function formalityThresholdsFor(
profile?: UserStyleProfile
): FormalityThresholds {
const primary = profile?.primaryArchetype;
if (primary === 'AVANT_GARDE') {
return {
hardPenalty: 0.85,
midPenalty: 0.8,
softPenalty: 0.7,
mismatchTag: 0.7,
coherentTag: 0.35,
};
}
if (primary === 'SMART_CASUAL') {
return {
hardPenalty: 0.7,
midPenalty: 0.65,
softPenalty: 0.55,
mismatchTag: 0.55,
coherentTag: 0.3,
};
}
return {
hardPenalty: 0.55,
midPenalty: 0.4,
softPenalty: 0.25,
mismatchTag: 0.45,
coherentTag: 0.25,
};
}

export function evaluateCoherence(
products: ScoredProduct[],
profile?: UserStyleProfile
): CoherenceScores {
const reasons: string[] = [];
if (products.length === 0) {
return {
Expand All @@ -33,16 +75,17 @@ export function evaluateCoherence(products: ScoredProduct[]): CoherenceScores {
if (colorHarmony > 0.8) reasons.push('color_harmony_strong');
else if (colorHarmony < 0.45) reasons.push('color_harmony_weak');

const thresholds = formalityThresholdsFor(profile);
const formalities = products.map((p) => p.formality);
const minF = Math.min(...formalities);
const maxF = Math.max(...formalities);
const spread = maxF - minF;
let formalitySpread = 1;
if (spread > 0.55) formalitySpread = 0.35;
else if (spread > 0.4) formalitySpread = 0.6;
else if (spread > 0.25) formalitySpread = 0.85;
if (spread < 0.25) reasons.push('formality_coherent');
if (spread > 0.45) reasons.push('formality_mismatch');
if (spread > thresholds.hardPenalty) formalitySpread = 0.35;
else if (spread > thresholds.midPenalty) formalitySpread = 0.6;
else if (spread > thresholds.softPenalty) formalitySpread = 0.85;
if (spread < thresholds.coherentTag) reasons.push('formality_coherent');
if (spread > thresholds.mismatchTag) reasons.push('formality_mismatch');

const archetypeTotals: Record<string, number> = {};
for (const p of products) {
Expand Down
7 changes: 4 additions & 3 deletions src/engine/v2/composer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,10 @@ function assembleReasons(
}

function scoreComposition(
products: ScoredProduct[]
products: ScoredProduct[],
profile: UserStyleProfile
): { coherence: ReturnType<typeof evaluateCoherence>; score: number } {
const coherence = evaluateCoherence(products);
const coherence = evaluateCoherence(products, profile);
const productAvg =
products.reduce((acc, p) => acc + p.score, 0) / Math.max(1, products.length);
const baseScore = productAvg * 0.55 + coherence.combined * 0.45;
Expand Down Expand Up @@ -274,7 +275,7 @@ function composeForOccasion(
if (seenSignatures.has(signature)) continue;
seenSignatures.add(signature);

const { coherence, score } = scoreComposition(products);
const { coherence, score } = scoreComposition(products, profile);
if (score < 0.35) continue;

candidates.push({
Expand Down