fix(engine/v2): strengthen diversifier + product re-use penalty#56
Open
lucavandee wants to merge 1 commit into
Open
fix(engine/v2): strengthen diversifier + product re-use penalty#56lucavandee wants to merge 1 commit into
lucavandee wants to merge 1 commit into
Conversation
- Product appearance cap: 1× when pool has >= count*3 unique products, else 2× - Strict overlap threshold lowered from 0.34 to 0.25 - Per-slot collision penalty (-0.20) for footwear/bottom/outerwear reuse - Reuse penalty (-0.15) per product already in a selected outfit - Strict footwear uniqueness when pool has >= 3 unique footwear items - Track usedProductIds across the set so ranking prefers fresh candidates Addresses R7 regression where same products (e.g. Clarks desert boot, Levi's 568, Nike Dunk) appeared in multiple outfits per persona. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
✅ Deploy Preview for fitfiai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usedProductIdsacross the whole set, with dynamic re-ranking per selection step.Addresses the R7 diversity regression (avg 5/10) where the same products appeared in multiple outfits per persona — e.g. Clarks desert boot 2× (Thomas, Pieter), Levi's 568 2× and Nike Dunk 2× (Jayden), Adidas Stan Smith 2× (Pieter).
Test plan
npx vitest run— 55 passing; the 1 failing test (productClassifier) is pre-existing onmainand unrelated to this change.🤖 Generated with Claude Code