Smooth VUEs amendment#600
Open
jerethk wants to merge 1 commit intoluciusDXL:masterfrom
Open
Conversation
…e is transiting across 0 / 360 degrees between frames For example, if changing from 358 degrees to 2 degrees, we want to interpolate upwards (358, 359, 0, 1, 2) not downwards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing interpolation logic (introduced by #288) does not take into account the wrapping-around of angles at 360 degrees.
So, if an angle (eg. yaw) is 358 degrees in one frame and 2 degrees in the next frame, the interpolation will happen downwards from 358 to 2, instead of upwards (358, 359, 0, 1, 2).
This is not an issue with 3d-object VUEs, which ignore the angles and use the transformation matrix to render each keyframe. But it is noticed when using VUEs in camera mode, to move a camera or sprite around.
I think the solution to this is to test whether the delta is more than 180 degrees -- if so, interpolate via the shorter distance arc