fix(hive): type service worker runtime deps and add E2E envelope test#12
Merged
fix(hive): type service worker runtime deps and add E2E envelope test#12
Conversation
This gives the service worker's runtime deps an explicit type so the compiler validates the handler wiring instead of trusting an untyped object. The fetch dependency is now also explicit: it delegates to self.fetch rather than falling through to an ambient global. It also adds a test for the E2E envelope path — where a push payload contains a beebuzz envelope with an attachment token, the worker fetches the ciphertext, decrypts it, and shows the notification. This documents the flow and protects it from regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the service worker's runtime deps an explicit type so the compiler validates the handler wiring instead of trusting an untyped object. The fetch dependency is now also explicit: it delegates to self.fetch rather than falling through to an ambient global.
It also adds a test for the E2E envelope path — where a push payload contains a beebuzz envelope with an attachment token, the worker fetches the ciphertext, decrypts it, and shows the notification. This documents the flow and protects it from regressions.