fix: do not keep raw inspect tokens in memory#13
Merged
Conversation
The inspect flow is a temporary debugging utility with a 10-minute TTL. It lets an authenticated user capture one payload from a third-party service so they can configure webhook parsing correctly. Even though this token is short-lived and scoped to a single user, we were keeping the raw token in memory alongside its hash. That is unnecessary exposure. This change removes the Token field from InspectSession so only the hash is stored in memory. The raw token is still returned once to the caller (so the user gets their inspect URL), but after that it only exists as a hash. This matches how we already handle webhook tokens, and it is just good memory hygiene.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspect flow is a temporary debugging utility with a 10-minute TTL. It lets an authenticated user capture one payload from a third-party service so they can configure webhook parsing correctly. Even though this token is short-lived and scoped to a single user, we were keeping the raw token in memory alongside its hash. That is unnecessary exposure.
This change removes the Token field from InspectSession so only the hash is stored in memory. The raw token is still returned once to the caller (so the user gets their inspect URL), but after that it only exists as a hash. This matches how we already handle webhook tokens, and it is just good memory hygiene.