fix(hive): resolve push handling regressions and improve notification UX#20
Merged
fix(hive): resolve push handling regressions and improve notification UX#20
Conversation
Owner
lucor
commented
May 5, 2026
lucor
commented
- Make Service Worker resilient to IndexedDB upgrade blocks during push by creating the DB on-demand when it does not exist yet.
- Harden notification click flow: best-effort focus/openWindow, catch malformed client URLs, and persist after opening to avoid Android activation stalls.
- Remove redundant E2E envelope null check after type guard.
- Improve relative time formatting: show seconds for recent messages, absolute HH:MM for same-day >1h and previous days.
- Expand test coverage for SW push, click, credentials, and bootstrap.
- Make Service Worker resilient to IndexedDB upgrade blocks during push by creating the DB on-demand when it does not exist yet. - Harden notification click flow: best-effort focus/openWindow, catch malformed client URLs, and persist after opening to avoid Android activation stalls. - Remove redundant E2E envelope null check after type guard. - Improve relative time formatting: show seconds for recent messages, absolute HH:MM for same-day >1h and previous days. - Expand test coverage for SW push, click, credentials, and bootstrap.
TypeScript does not narrow the destructured 'envelope' binding even after isE2EEnvelope() returns true because 'beebuzz' is optional in the E2EEnvelope type. Add an explicit null check to satisfy the compiler and match the pre-squash behavior.
- Disable svelte/prefer-svelte-reactivity for new Date() instances in formatRelativeTime, which is a pure utility function, not Svelte state. - Disable @typescript-eslint/no-unsafe-assignment for vitest's expect.objectContaining matcher in the credentials-failure test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.