fix: Apple Maps marker scale and callout positioning#41
Merged
Conversation
- Reset iconView transform before reading bounds to avoid undefined frame reads - Set bounds/center before applying scale transform so icons actually scale - Fix centerOffset x-component sign (was inverted for non-centered anchors)
Use dispatch_after debounce instead of hard-coded delta threshold to detect scale changes. Live iconView is used during rapid updates to avoid expensive rasterization per frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconViewtransform during rapid updates, rasterizes after 150ms idle to avoid expensive image generation per framecenterOffsetcalculation for non-default anchorsType of Change
Test Plan
Checklist