Initial work done on the deferred initialization of angular-facebook#80
Open
mdedetrich wants to merge 2 commits intoluiscarlosjayk:masterfrom
Open
Initial work done on the deferred initialization of angular-facebook#80mdedetrich wants to merge 2 commits intoluiscarlosjayk:masterfrom
mdedetrich wants to merge 2 commits intoluiscarlosjayk:masterfrom
Conversation
- Only initialize with facebook settings if they are defined
|
FYI I have been using this for almost a year now and never had any issues with it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is initial work for deferred init, a lot more work still needs to be done, and all of the tests need to redone as well
Relates to #36