Added check if FB SDK has already loaded on page, otherwise fbAsyncInit ...#94
Open
dreamoftrees wants to merge 3 commits intoluiscarlosjayk:masterfrom
Open
Added check if FB SDK has already loaded on page, otherwise fbAsyncInit ...#94dreamoftrees wants to merge 3 commits intoluiscarlosjayk:masterfrom
dreamoftrees wants to merge 3 commits intoluiscarlosjayk:masterfrom
Conversation
…it is never called
Collaborator
|
Hi @dreamoftrees, can you provide a little example how to reproduce this ? |
…o fix/fb-sdk-already-loaded
|
This pull request actually fixed the bug I experienced only in Firefox. When opening my website via new tab, the SDK was cached. When switching to the controller, the Facebook plugin would never report ready status. Firefox appears to use the cached version and does not initiate the $window.fbAsyncInit call. Using Firefox 43.0.4. This does not occur in Chrome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for all your work on this I've found it really helpful. I noticed in some instances possibly when the SDK is cached locally that $window.fbAsyncInit is called before it's declared below. Meaning the FB SDK will never trigger the initialisation of this class.
I've just added a small check to see if the FB SDK already exists then just init directly. Hope that makes sense. Sorry this is my first pull request, let me know if I can help in any other way.
Thanks again,
Charlie