Skip to content

Fix unintended extra short beep on package start #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukash merged 2 commits into from
Jan 31, 2026
Merged

Fix unintended extra short beep on package start #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b549af9
Add macOS build instruction and support spaces in vesc_tool path
0x41kravchenko Jan 29, 2026
916b09d
Drive beeper pin low after init to prevent unintended beep
0x41kravchenko Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ all: refloat.vescpkg

refloat.vescpkg: src lisp/package.lisp package_README-gen.md ui.qml
ifeq ($(OLDVT), 1)
$(VESC_TOOL) --buildPkg "refloat.vescpkg:lisp/package.lisp:ui.qml:0:package_README-gen.md:Refloat"
"$(VESC_TOOL)" --buildPkg "refloat.vescpkg:lisp/package.lisp:ui.qml:0:package_README-gen.md:Refloat"
else
$(VESC_TOOL) --buildPkgFromDesc pkgdesc.qml
"$(VESC_TOOL)" --buildPkgFromDesc pkgdesc.qml
endif

src:
Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ If you don't have `vesc_tool` in your `$PATH` (but you have, for example, a down
```sh
make VESC_TOOL=/path/to/vesc_tool
```
For macOS, the path to VESC Tool when installed using the official installer is as follows:
```sh
make VESC_TOOL="/Applications/VESC Tool.app/Contents/MacOS/VESC Tool"
```

## Documentation
[Development Documentation](doc/index.md)
5 changes: 5 additions & 0 deletions src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ const VESC_PIN beeper_pin = VESC_PIN_PPM;

void beeper_init() {
VESC_IF->io_set_mode(beeper_pin, VESC_PIN_MODE_OUTPUT);
VESC_IF->io_write(beeper_pin, 0);
}

void beeper_update(Data *d) {
Expand Down Expand Up @@ -1232,6 +1233,10 @@ static void data_init(Data *d) {
);

d->odometer = VESC_IF->mc_get_odometer();

d->beep_num_left = 0;
d->beep_duration = 0;
d->beep_countdown = 0;
}

// See also:
Expand Down
Loading