Open
Conversation
Added the color option, and also reorganized the command line parameters to make them easier to review in code.
To align to British spelling, per the pipeline tests.
Author
|
Changed the parameter to --no-colour and updated the docs/code as appropriate, so it would pass the pipeline spell check. :) |
Author
|
I also notice on the README you said the next major version may switch to US English? If so, I can a) put color back, and b) update the pipeline to force english spell checking, which should allow it to pass the CI. |
|
@lukeapage Could this please be merged? It would be very helpful |
|
Hello and thanks for all of this work! As an end user, I'm giving a 👍 to this feature. Not only this spellchecker is NEAT, but also this feature ! |
11 tasks
|
This merge would be so incredibly helpful, I don't suppose it could be merged in @robatwilliams or @lukeapage? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36. This is an attempt to add the command line parameter to support no color mode.
[[[mistaeks]]].Two outstanding questions for feedback:
I couldn't find any CONTRIBUTING guidelines, so I am simply submitting straight into
master. Hope that's ok!