Open
Conversation
…lowed to use thread local before CRT initialization
SuspendThread is not enough to guarantee safe initialization of bookkeeping data
…ntly. Remove the need to manually update MinHook project when upgrading Visual C++.
I decided to ditch the changes to make the profiler not use malloc for now. They didn't compile. I'll resurrect these after assesing whether some third party hash table would do the job better. # Conflicts: # Heapy/Heapy.vcxproj # HeapyInject/HeapyInject.vcxproj # ProfileTestApplication/ProfileTestApplication.vcxproj # Readme.md # TestApplication/TestApplication.vcxproj # libs/MinHook/build/VC12/libMinHook.vcxproj # libs/MinHook/src/HDE/hde32.h # libs/MinHook/src/HDE/hde64.h # libs/MinHook/src/hook.cpp # libs/MinHook/src/trampoline.cpp
Owner
|
I honestly can't remember what happened with this line of work - but I'm looking at incorporating these changes now @jackylai0. I'm planning on adding some other features soon and wanted a good starting point. Branch merge_jackylais_work. |
Author
@lukedodd You mean HeapAllocator? It is based on VS2010 std::allocator and modify to use HeapAlloc/HeapFree instead. Maybe std::allocator changes is too extensive and have to re-adapted for VS2019. |
Need to turn off optimization for StackTrace::trace().
Author
|
@lukedodd Please check my latest commits. I merged your branch again and fixed various bugs (including HeapAllocator compile error). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
New: