Updated docker file for supported node versions, npm and latest release. - #172
Open
devilankur18 wants to merge 1 commit into
Open
Updated docker file for supported node versions, npm and latest release.#172devilankur18 wants to merge 1 commit into
devilankur18 wants to merge 1 commit into
Conversation
fudali
reviewed
Mar 6, 2019
| USER node | ||
| RUN mkdir /home/node/.npm-global | ||
| ENV PATH=/home/node/.npm-global/bin:$PATH | ||
| ENV NPM_CONFIG_PREFIX=/home/node/.npm-global |
Contributor
There was a problem hiding this comment.
can you explain why do you need to set user node and do anything with .npm-global dir?
There was a problem hiding this comment.
I got some permission errors when trying to build the docker image in the master version.
These changes (lines 10 to 13) made by @devilankur18 fixed the problem for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.