Fix list field on 1.5 / Filament 4#2415
Open
ryanmitchell wants to merge 4 commits intolunarphp:1.xfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Filament 4 / Lunar 1.5 beta incompatibility where the List field can be treated as a non-string during JSON handling, causing json_decode() type errors, by making Lunar\FieldTypes\ListField implement Arrayable.
Changes:
- Implement
Illuminate\Contracts\Support\ArrayableonListField. - Add
toArray()to provide an array representation of the List field value for Filament 4 compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list field on the 1.5 beta currently fails with the error
json_decode(): Argument #1 ($json) must be of type string, Lunar\FieldTypes\ListField giventhis PR changes the field type to be arrayable to get around this.