Fix non-deterministic activity log order for same-second events#2427
Open
AltinEtemaj wants to merge 1 commit intolunarphp:1.xfrom
Open
Fix non-deterministic activity log order for same-second events#2427AltinEtemaj wants to merge 1 commit intolunarphp:1.xfrom
AltinEtemaj wants to merge 1 commit intolunarphp:1.xfrom
Conversation
Sort activity log entries by `id` instead of `created_at` to ensure correct chronological order when multiple events occur within the same second (e.g. order created, updated, and placed during checkout).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Report
Description
The order timeline in the admin panel displays activity log entries in a non-deterministic order when multiple events occur within the same second. This causes entries like "order updated" to appear before "order created", which is confusing and incorrect.
Root Cause
In
ActivityLogFeed.php, activities are sorted bycreated_at:When an order is placed, multiple activity log entries are created within the same request cycle (order created, order updated, order line created, payment capture, etc.). These all share the exact same
created_attimestamp, so the database returns them in an undefined order.Steps to Reproduce
Fix
Replace
orderBy('created_at', 'desc')withorderBy('id', 'desc'). The auto-incrementingidcolumn preserves the true insertion order, even when multiple events share the same timestamp.