Open
Conversation
Using pass_through fails when behind a proxy (e.g. corporate network
with http_proxy/https_proxy environment variables):
$ https_proxy=http://proxy:8080 python
>>> with respx.mock:
... respx.route().pass_through()
... httpx.get("https://example.com")
httpx.InvalidURL: Invalid port: 8080example.com:443
Bypass CONNECT requests in HTTPCoreMocker to allow proxy tunnel
establishment.
Author
|
First, thank you for making respx, very neat! This PR is a compromise, a small implementation which I think could solve a real issue for users, namely using this library behind a proxy. I ran into this myself when using Anthropic web based Claude Code offering, which is behind a proxy. However this also means mocking the proxy CONNECT request will not work properly, which is not great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
pass_throughin a proxy environment cause requests to fail:When a proxy is configured, httpcore sends a CONNECT request to establish a tunnel. This request uses authority-form URLs (e.g. example.com:443) with no scheme. When respx intercepts this request and tries to parse it into an httpx.URL, the parser crashes.
This PR simply bypass CONNECT requests at the mocker level, before URL parsing occurs.
Note
This means users cannot mock CONNECT requests (e.g. to simulate a 407 Proxy Authentication Required).