Skip to content

update lune-roblox to latest Roblox packages #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filiptibell merged 2 commits into from
Jul 2, 2026
Merged

update lune-roblox to latest Roblox packages #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01d5b0e
update lune-roblox to latest packages
alicesaidhi Jul 2, 2026
7cde94d
remove minor package versions
alicesaidhi Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 36 additions & 105 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions crates/lune-roblox/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ glam = "0.33"
rand = "0.10"
thiserror = "2.0"

rbx_binary = "2.0"
rbx_binary = "3.0"
rbx_dom_weak = "4.0"
rbx_reflection = "6.0"
rbx_reflection_database = "2.0"
rbx_xml = "2.0"
rbx_reflection = "7.0"
rbx_reflection_database = "3.0"
rbx_xml = "3.0"

lune-utils = { version = "0.3.4", optional = true, path = "../lune-utils" }
2 changes: 1 addition & 1 deletion crates/lune-roblox/src/instance/query/matcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ fn enum_value_matches(enum_name: &str, value: u32, literal: &str) -> bool {
db.enums.get(enum_name).is_some_and(|desc| {
desc.items
.iter()
.any(|(name, item_value)| name.as_ref() == literal && *item_value == value)
.any(|(name, item_value)| name == &literal && *item_value == value)
})
}

Expand Down
4 changes: 2 additions & 2 deletions crates/lune-roblox/src/instance/terrain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ fn get_or_create_material_colors(instance: &Instance) -> MaterialColors {
fn terrain_get_material_color(_: &Lua, this: &Instance, material: EnumItem) -> LuaResult<Color3> {
let material_colors = get_or_create_material_colors(this);

if &material.parent.desc.name != "Material" {
if material.parent.desc.name != "Material" {
return Err(LuaError::RuntimeError(format!(
"Expected Enum.Material, got Enum.{}",
&material.parent.desc.name
Expand Down Expand Up @@ -75,7 +75,7 @@ fn terrain_set_material_color(
let material = args.0;
let color = args.1;

if &material.parent.desc.name != "Material" {
if material.parent.desc.name != "Material" {
return Err(LuaError::RuntimeError(format!(
"Expected Enum.Material, got Enum.{}",
&material.parent.desc.name
Expand Down
2 changes: 1 addition & 1 deletion crates/lune-roblox/src/reflection/class.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ impl fmt::Display for DatabaseClass {
#[cfg(feature = "mlua")]
fn find_enum_name(inner: DbClass, name: impl AsRef<str>) -> Option<String> {
inner.properties.iter().find_map(|(prop_name, prop_info)| {
if prop_name == name.as_ref() {
if prop_name == &name.as_ref() {
if let DataType::Enum(enum_name) = &prop_info.data_type {
Some(enum_name.to_string())
} else {
Expand Down
Loading