[WRONG BRANCH] fix(state): close capped recovery iterators - #196
Conversation
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
recoverStaleResponseStateTempsabandoned a directory generator when the scan hit an injected cap, losing the generator'sfinallycleanup and potentially leaking an open directory handle.Description
iterator.return()from a best-effortfinallyblock when the recovery loop exits early.stale temp recovery closes an enumeration iterator when it reaches a capintests/responses-state.test.tsthat proves a generator'sfinallyblock runs when enumeration stops at a cap.Testing
bun run test tests/responses-state.test.ts, which passed all tests in that file (98 passed, 0 failed).bun run typecheckwhich completed successfully.bun run privacy:scanwhich reported "Privacy scan passed" for the working tree.bun run testwas attempted but encountered unrelated timeouts in other test modules; the change is covered by the focused response-state tests which pass.Codex Task