Skip to content

[WRONG BRANCH] fix(state): close capped recovery iterators - #196

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-iterator-cleanup-regression
Draft

[WRONG BRANCH] fix(state): close capped recovery iterators#196
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-iterator-cleanup-regression

Conversation

@luvs01

@luvs01 luvs01 commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A manual iterator loop in recoverStaleResponseStateTemps abandoned a directory generator when the scan hit an injected cap, losing the generator's finally cleanup and potentially leaking an open directory handle.

Description

  • Restore iterator-close semantics by tracking natural exhaustion and invoking iterator.return() from a best-effort finally block when the recovery loop exits early.
  • Preserve the capped, best-effort cleanup behaviour and existing failure containment so unlink/inspect failures still degrade without crashing.
  • Add a focused regression test stale temp recovery closes an enumeration iterator when it reaches a cap in tests/responses-state.test.ts that proves a generator's finally block runs when enumeration stops at a cap.

Testing

  • Ran the focused suite with bun run test tests/responses-state.test.ts, which passed all tests in that file (98 passed, 0 failed).
  • Ran bun run typecheck which completed successfully.
  • Ran bun run privacy:scan which reported "Privacy scan passed" for the working tree.
  • A full bun run test was attempted but encountered unrelated timeouts in other test modules; the change is covered by the focused response-state tests which pass.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 860f7bd2-2e91-4bad-9fa7-ea16bba3d7f2

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and 14da75d.

📒 Files selected for processing (2)
  • src/responses/state.ts
  • tests/responses-state.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions github-actions Bot changed the title fix(state): close capped recovery iterators [WRONG BRANCH] fix(state): close capped recovery iterators Aug 9, 2026
@github-actions
github-actions Bot marked this pull request as draft August 9, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant