Skip to content

[WRONG BRANCH] fix(gui): tolerate unavailable model preference storage - #198

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-crash-on-models-page-without-localstorage
Draft

[WRONG BRANCH] fix(gui): tolerate unavailable model preference storage#198
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-crash-on-models-page-without-localstorage

Conversation

@luvs01

@luvs01 luvs01 commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The storage helpers used storage: StorageLike = localStorage defaults, which evaluate localStorage before the function body and can throw in SSR/tests or hardened browsers, causing the Models page to crash during render.

Description

  • Change readCollapsedProviders and writeCollapsedProviders to accept an optional storage?: StorageLike and resolve const target = storage ?? localStorage inside the protected try block so global access failures are caught.
  • Preserve existing read/write semantics when localStorage is available by delegating to the resolved target for getItem/setItem calls.
  • Add gui/tests/models-storage.test.ts to cover both an absent localStorage and a global getter that throws a SecurityError, ensuring the helpers return safely and do not throw.

Testing

  • Ran the new focused test with cd gui && bun test tests/models-storage.test.ts, which passed.
  • Ran the full GUI test suite with cd gui && bun test tests, which executed many tests successfully but surfaced pre-existing unrelated failures (timer helpers and a Node zlib export issue); summary: the suite produced passing tests but included unrelated failures (651 passed, 9 failed, 1 error) that are not caused by this change.
  • Ran lint and build with cd gui && bun run lint and cd gui && bun run build, both completed successfully (build emitted a large-chunk advisory only).
  • Ran typecheck with bun run typecheck, which completed successfully.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a48170ec-d0bd-4826-a793-9e4b62c7a5ee

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and aa64ab9.

📒 Files selected for processing (2)
  • gui/src/pages/models-shared.ts
  • gui/tests/models-storage.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions github-actions Bot changed the title fix(gui): tolerate unavailable model preference storage [WRONG BRANCH] fix(gui): tolerate unavailable model preference storage Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 9, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant