[WRONG BRANCH] fix(gui): tolerate unavailable model preference storage - #198
[WRONG BRANCH] fix(gui): tolerate unavailable model preference storage#198luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
storage: StorageLike = localStoragedefaults, which evaluatelocalStoragebefore the function body and can throw in SSR/tests or hardened browsers, causing the Models page to crash during render.Description
readCollapsedProvidersandwriteCollapsedProvidersto accept an optionalstorage?: StorageLikeand resolveconst target = storage ?? localStorageinside the protectedtryblock so global access failures are caught.localStorageis available by delegating to the resolvedtargetforgetItem/setItemcalls.gui/tests/models-storage.test.tsto cover both an absentlocalStorageand a global getter that throws aSecurityError, ensuring the helpers return safely and do not throw.Testing
cd gui && bun test tests/models-storage.test.ts, which passed.cd gui && bun test tests, which executed many tests successfully but surfaced pre-existing unrelated failures (timer helpers and a Nodezlibexport issue); summary: the suite produced passing tests but included unrelated failures (651 passed, 9 failed, 1 error) that are not caused by this change.cd gui && bun run lintandcd gui && bun run build, both completed successfully (build emitted a large-chunk advisory only).bun run typecheck, which completed successfully.Codex Task