Skip to content

[WRONG BRANCH] fix(routing): ignore inherited modelMap keys - #199

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-alias-update-collision-detection
Draft

[WRONG BRANCH] fix(routing): ignore inherited modelMap keys#199
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-alias-update-collision-detection

Conversation

@luvs01

@luvs01 luvs01 commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent false-positive alias collisions when migrating claudeCode.modelMap keys by avoiding prototype property reads such as constructor or toString that are not real map entries.

Description

  • Replace prototype-reading existence checks with own-property checks using Object.hasOwn(map, ...) in modelMapMigrationCollision to detect real modelMap keys only.
  • Add a regression test in tests/routing-profile-management-editor.test.ts that verifies renaming a profile alias to constructor succeeds and migrates the model map entry.

Testing

  • Ran the focused test: bun test tests/routing-profile-management-editor.test.ts -t "ignores inherited modelMap properties", and the new regression test passed.
  • Ran bun run typecheck (bun x tsc --noEmit) and it completed successfully.
  • Ran the full test suite (bun run test); many tests passed but some unrelated Grok model-list tests experienced environment timeouts in this run, so the broader suite was not fully green in this environment (these failures are pre-existing/time-limited and not caused by this change).

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e5566eef-f3e9-4af6-a2f7-d02e3343305e

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and 3d07101.

📒 Files selected for processing (2)
  • src/server/management/routing-profile-routes.ts
  • tests/routing-profile-management-editor.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions github-actions Bot changed the title fix(routing): ignore inherited modelMap keys [WRONG BRANCH] fix(routing): ignore inherited modelMap keys Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 9, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant