Skip to content

[WRONG BRANCH] fix(vision): bound validation error prompts - #201

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unbounded-image-mime-error
Draft

[WRONG BRANCH] fix(vision): bound validation error prompts#201
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unbounded-image-mime-error

Conversation

@luvs01

@luvs01 luvs01 commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A data-URL mime validation path could reflect an unbounded attacker-controlled media-type string into the replacement prompt, allowing prompt/context amplification and excessive provider cost or latency.
  • The goal is to cap and sanitize any validation/error text and to enforce a small, well-formed MIME syntax/length limit so errors cannot become large attacker-controlled text in the main provider prompt.

Description

  • Enforce a MIME syntax check and a MAX_MIME_CHARS (127) bound in validateImageUrl() and return a small canonical error ("invalid image media type") for oversized or syntactically invalid media types (file: src/vision/describe.ts).
  • Add boundedError() in src/vision/index.ts to strip control characters and clamp error text to DESC_MAX_CHARS, and use it when rendering sidecar errors so they cannot expand the upstream prompt.
  • Preserve the existing per-image clamping for successful descriptions and ensure error markers are treated the same way before insertion into message parts.
  • Add a regression test in tests/vision-cache.test.ts that verifies oversized data-URL media types are rejected without echoing long input and that thrown/sidecar errors are sanitized and size-bounded.

Testing

  • node_modules/@oven/bun-linux-x64-baseline/bin/bun test tests/vision-cache.test.ts — passed (focused regression tests succeeded).
  • PATH="$PWD/node_modules/@oven/bun-linux-x64-baseline/bin:$PATH" bun run test — passed (full test suite run with the pinned baseline Bun binary succeeded).
  • bun run typecheck — succeeded (typecheck passed).
  • bun run privacy:scan — succeeded (privacy scan passed).
  • Note: the system-installed Bun (bun test tests/vision-cache.test.ts) was an older runtime (1.2.14) which produced an unrelated node:zlib export mismatch, so the repository-pinned Bun binary was used for reliable test execution.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 722a8dd1-3209-480b-99cc-2828297f1b94

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and 0b9f5d7.

📒 Files selected for processing (3)
  • src/vision/describe.ts
  • src/vision/index.ts
  • tests/vision-cache.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions github-actions Bot changed the title fix(vision): bound validation error prompts [WRONG BRANCH] fix(vision): bound validation error prompts Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 9, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant