[WRONG BRANCH] fix(integrations): refuse unsafe TOML integers - #202
[WRONG BRANCH] fix(integrations): refuse unsafe TOML integers#202luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9d0f780ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Bun.TOML.parse returns TOML integers as JavaScript numbers. Values outside | ||
| // the safe range may already have been rounded, so writing them back would | ||
| // silently alter a user-owned config rather than merely reformatting it. | ||
| if (Number.isInteger(value) && !Number.isSafeInteger(value)) { |
There was a problem hiding this comment.
Distinguish TOML floats from unsafe integers
In src/integrations/serialize.ts, when a valid TOML float has an integral JavaScript value—for example k = 1e20 or k = 9007199254740992.0—Bun returns a number for which Number.isInteger is true, so this branch misclassifies it as a TOML integer and makes integration apply/disable refuse the entire file. This changes previously accepted scalar behavior even though the fix targets unsafe integer literals; validate integer tokens from the raw TOML before parsing, as the special-float guard does, or otherwise preserve the parsed numeric kind instead of inferring the TOML type with Number.isInteger.
AGENTS.md reference: src/AGENTS.md:L10-L10
Useful? React with 👍 / 👎.
Motivation
Description
tomlScalarinsrc/integrations/serialize.tsto throwUnserializableValueErrorfor integer numbers whereNumber.isInteger(value)is true butNumber.isSafeInteger(value)is false, preserving other scalar rendering behavior.tests/integrations-serialize.test.tsassertingrenderTomlrefuses integers outside the safe range and an integration regression intests/integrations-invariants.test.tsthat proves a Kimi TOML file with9007199254740993is refused and left unchanged.Testing
bun test tests/integrations-serialize.test.ts tests/integrations-invariants.test.tsand observed the added tests pass in the focused run.bun run typecheckandbun run privacy:scan, both succeeded.bun run test; most suites passed but unrelated environment-dependent failures/timeouts appeared in some integration areas (Grok model-list and certain Docker/service CLI tests), which are unrelated to this change.Codex Task