Skip to content

[WRONG BRANCH] fix(integrations): refuse unsafe TOML integers - #202

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-toml-precision-loss
Draft

[WRONG BRANCH] fix(integrations): refuse unsafe TOML integers#202
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-toml-precision-loss

Conversation

@luvs01

@luvs01 luvs01 commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent silently corrupting user-owned TOML files when parsed TOML integers exceed JavaScript's safe integer range and become rounded by the runtime parser.

Description

  • Update tomlScalar in src/integrations/serialize.ts to throw UnserializableValueError for integer numbers where Number.isInteger(value) is true but Number.isSafeInteger(value) is false, preserving other scalar rendering behavior.
  • Keep support for arrays of mixed scalars while ensuring unsafe integers are rejected rather than written back.
  • Add a unit test in tests/integrations-serialize.test.ts asserting renderToml refuses integers outside the safe range and an integration regression in tests/integrations-invariants.test.ts that proves a Kimi TOML file with 9007199254740993 is refused and left unchanged.

Testing

  • Ran focused serializer tests: bun test tests/integrations-serialize.test.ts tests/integrations-invariants.test.ts and observed the added tests pass in the focused run.
  • Ran type checking with bun run typecheck and bun run privacy:scan, both succeeded.
  • Ran broader bun run test; most suites passed but unrelated environment-dependent failures/timeouts appeared in some integration areas (Grok model-list and certain Docker/service CLI tests), which are unrelated to this change.

Codex Task

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8359a7c8-7a46-413a-ba4d-da8b0939737d

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and b9d0f78.

📒 Files selected for processing (3)
  • src/integrations/serialize.ts
  • tests/integrations-invariants.test.ts
  • tests/integrations-serialize.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions github-actions Bot changed the title fix(integrations): refuse unsafe TOML integers [WRONG BRANCH] fix(integrations): refuse unsafe TOML integers Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 9, 2026 05:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9d0f780ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

// Bun.TOML.parse returns TOML integers as JavaScript numbers. Values outside
// the safe range may already have been rounded, so writing them back would
// silently alter a user-owned config rather than merely reformatting it.
if (Number.isInteger(value) && !Number.isSafeInteger(value)) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Distinguish TOML floats from unsafe integers

In src/integrations/serialize.ts, when a valid TOML float has an integral JavaScript value—for example k = 1e20 or k = 9007199254740992.0—Bun returns a number for which Number.isInteger is true, so this branch misclassifies it as a TOML integer and makes integration apply/disable refuse the entire file. This changes previously accepted scalar behavior even though the fix targets unsafe integer literals; validate integer tokens from the raw TOML before parsing, as the special-float guard does, or otherwise preserve the parsed numeric kind instead of inferring the TOML type with Number.isInteger.

AGENTS.md reference: src/AGENTS.md:L10-L10

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant