[WRONG BRANCH] fix(grok): preserve orphan model tables that have no replacement - #208
[WRONG BRANCH] fix(grok): preserve orphan model tables that have no replacement#208luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
[model.<alias>]tables unconditionally which could delete the only table named by[models] defaultorfork_secondary_model, leaving dangling references when no replacement is emitted.Description
modelid appears in the set of model ids that will be emitted (honouringopts.excluded).src/grok/inject.tsto computeemittedModelIdsand filterfindOpencodexOrphansaccordingly before callingremoveOrphanTables.tests/grok-orphan-adoption.test.tsto assert that an orphan whose model is no longer in the catalog is preserved and to add a test that an orphan remains when its catalog model is explicitly excluded.src/grok/inject.ts,tests/grok-orphan-adoption.test.ts.Testing
bun test tests/grok-orphan-adoption.test.ts, which passed all 19 tests in that file.bun run typecheck, which completed successfully.bun run privacy:scan, which completed successfully.bun run testduring validation but that run encountered unrelated failures/timeouts in other subsystems; the targeted Grok tests listed above passed independently.Codex Task