[WRONG BRANCH] fix(anthropic): validate upstream tool names - #214
Conversation
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
tool_use.name(non-string) whileescapeBuiltinToolNamesis enabled, which previously causedname.startsWith(...)TypeErrors and failed requests.Description
content_block.name/content[].nameas untrusted by changing their local typing tounknownand only invokingtoolNames.fromWire(...)when the name is astringin both streaming and non-streaming paths (src/adapters/anthropic.ts).tool_use.namefor both streaming and non-streaming parsing withescapeBuiltinToolNamesenabled (tests/anthropic-stream-hardening.test.ts).Testing
bun test tests/anthropic-stream-hardening.test.tsand the file's 20 tests passed (20 passed, 0 failed).bun run typecheckandbun run privacy:scan, both completed successfully in this environment.bun run testbut unrelated integration tests timed out in this environment, so the full-suite run was not green here (failures/timeouts were unrelated to the Anthropic changes).Codex Task