Skip to content

[WRONG BRANCH] fix(crash-guard): preserve application fault visibility - #216

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-benign-crash-classification-issue
Draft

[WRONG BRANCH] fix(crash-guard): preserve application fault visibility#216
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-benign-crash-classification-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The benign-classifier for off-path Bun teardown errors was too permissive and could suppress real application TypeErrors that only lacked a parenthesized stack frame or that carried Bun/JSC hidden throw-site fields.

Description

  • Restrict isBenignAbortTeardown so errors that expose Bun/JSC hidden source-location metadata (sourceURL, line, column, originalLine, originalColumn) are NOT treated as benign.
  • Broaden stack-frame detection to recognize both parenthesized and unparenthesized JavaScript source frames when deciding whether a stack is JS-locatable versus native-only.
  • Add focused regressions to tests/crash-guard.test.ts that cover unparenthesized frames and hidden JSC source fields, and adjust benign-case fixtures to explicitly clear hidden fields.
  • Preserve the existing rate-limited benign-summary path for genuinely native-only teardown shapes (e.g. the known ReadableStream is locked case).

Testing

  • Ran bun test tests/crash-guard.test.ts and all tests in that file passed.
  • Ran bun run typecheck and bun run privacy:scan which completed without errors.
  • Started the repository-wide bun run test; the focused changes passed locally but the full suite progressed before an isolated runner stall occurred and was stopped manually after long execution.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 52516fa7-4ee1-47c9-bc8f-5d75f9c6a7d3

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and 3c773a1.

📒 Files selected for processing (2)
  • src/lib/crash-guard.ts
  • tests/crash-guard.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(crash-guard): preserve application fault visibility [WRONG BRANCH] fix(crash-guard): preserve application fault visibility Aug 9, 2026
@github-actions
github-actions Bot marked this pull request as draft August 9, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant