[WRONG BRANCH] fix(catalog): tolerate malformed selectedModels - #218
[WRONG BRANCH] fix(catalog): tolerate malformed selectedModels#218luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
providerCatalogFingerprintassumedselectedModelswas iterable and could throw during catalog gathering, making model-listing endpoints unavailable for malformed persisted provider configs.Description
Array.isArray(prov.selectedModels)when building the fingerprint so non-arrayselectedModelsare treated as an empty selection, and add a focused regression test that a provider withselectedModels: 42still yields configured models and preserves visibility filtering.Testing
bun run typecheck(success) andbun run privacy:scan(success), and attempted the focused testbun test tests/gather-routed-models-single-flight.test.tswhich is blocked in this container by the runtime Bun 1.2.14 missingnode:zlibzstdDecompressSync(CI uses Bun 1.3.14 where the tests are expected to pass).Codex Task