Skip to content

[WRONG BRANCH] fix(catalog): tolerate malformed selectedModels - #218

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unvalidated-selectedmodels-issue
Draft

[WRONG BRANCH] fix(catalog): tolerate malformed selectedModels#218
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unvalidated-selectedmodels-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent a robustness regression where providerCatalogFingerprint assumed selectedModels was iterable and could throw during catalog gathering, making model-listing endpoints unavailable for malformed persisted provider configs.

Description

  • Use Array.isArray(prov.selectedModels) when building the fingerprint so non-array selectedModels are treated as an empty selection, and add a focused regression test that a provider with selectedModels: 42 still yields configured models and preserves visibility filtering.

Testing

  • Ran bun run typecheck (success) and bun run privacy:scan (success), and attempted the focused test bun test tests/gather-routed-models-single-flight.test.ts which is blocked in this container by the runtime Bun 1.2.14 missing node:zlib zstdDecompressSync (CI uses Bun 1.3.14 where the tests are expected to pass).

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7f5f302d-142b-48a6-957b-d500accdcfaf

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and f066c21.

📒 Files selected for processing (2)
  • src/codex/catalog/provider-fetch.ts
  • tests/gather-routed-models-single-flight.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions github-actions Bot changed the title fix(catalog): tolerate malformed selectedModels [WRONG BRANCH] fix(catalog): tolerate malformed selectedModels Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 9, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant