[WRONG BRANCH] fix(tests): isolate interpolation from React runtime - #227
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix(tests): isolate interpolation from React runtime#227luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe PR extracts i18n interpolation utilities into Changesi18n interpolation extraction
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
interpolatefromgui/src/i18n/shared.ts, which had a top-levelreactimport and caused the root test runner to require React even though the root package does not depend on it.Description
gui/src/i18n/interpolate.tsexportinginterpolate,Vars, andTFnfor non-React consumers.gui/src/i18n/shared.tsso existing GUI code remains source-compatible.interpolatefromgui/src/i18n/interpolateinstead ofshared.tsto avoid pulling React into the root test process.shared.tsto keeptsc/vitehappy about unused values.Testing
node_moduleshidden usingOCX_TEST_NO_QUEUE=1 bun scripts/test.ts tests/volcengine-providers.test.ts tests/tencent-siliconflow-providers.test.ts tests/provider-workspace-data.test.tsand observed all related tests pass (68 tests across those files passed).bun run typecheckwhich completed successfully.cd gui && bun run lint && bun run build && bun run lint:i18nwhich completed successfully.bun run privacy:scanwhich passed.bun run testwas started but the overall suite still surfaced unrelated existing failures/timeouts in other tests (pre-existing environment/version issues), so an entirely green full-suite run was not obtained in this environment.Codex Task
Summary by CodeRabbit
New Features
Refactor
Tests