[WRONG BRANCH] codex: tolerate non-string account plan values in quota and routing

src/codex/auth-api.ts

@@ -181,8 +181,8 @@ function codexAccountPersistenceConflict(
     : undefined;
 }
 
-function isThirtyDayOnlyPlan(plan: string | null | undefined): boolean {
-  const normalized = plan?.trim().toLowerCase();
+function isThirtyDayOnlyPlan(plan: unknown): boolean {
+  const normalized = typeof plan === "string" ? plan.trim().toLowerCase() : undefined;
   return normalized === "go" || normalized === "free";
 }
 

src/codex/routing.ts

@@ -314,9 +314,9 @@ function deleteScopedHealth(accountId: string, scope: CodexQuotaScope): void {
 export function computeCodexUsageScore(quota: {
   weeklyPercent?: number;
   monthlyPercent?: number;
-} | null, plan?: string | null): number {
+} | null, plan?: unknown): number {
   if (!quota) return CODEX_UNKNOWN_USAGE_SCORE;
-  const normalizedPlan = plan?.trim().toLowerCase();
+  const normalizedPlan = typeof plan === "string" ? plan.trim().toLowerCase() : undefined;
   if (normalizedPlan === "go" || normalizedPlan === "free") {
     return typeof quota.monthlyPercent === "number" && Number.isFinite(quota.monthlyPercent)
       ? quota.monthlyPercent

tests/codex-auth-api.test.ts

@@ -859,6 +859,31 @@ describe("codex-auth API", () => {
     }
   });
 
+  test("GET /api/codex-auth/accounts tolerates a non-string persisted plan", async () => {
+    const config = makeConfig({
+      codexAccounts: [
+        { id: "pool-invalid-plan", email: "invalid@example.test", plan: { tier: "go" }, isMain: false },
+      ] as unknown as OcxConfig["codexAccounts"],
+    });
+    saveCodexAccountCredential("pool-invalid-plan", {
+      accessToken: "access-invalid-plan",
+      refreshToken: "refresh-invalid-plan",
+      expiresAt: Date.now() + 5 * 60_000,
+      chatgptAccountId: "acct-invalid-plan",
+    });
+    updateAccountQuota("pool-invalid-plan", 91, 111, 33, 333);
+
+    const req = new Request("http://localhost/api/codex-auth/accounts", { method: "GET" });
+    const resp = await handleCodexAuthAPI(req, new URL(req.url), config);
+    const data = await resp!.json() as { accounts: Array<{ id: string; quota?: Record<string, unknown> }> };
+
+    expect(resp?.status).toBe(200);
+    expect(data.accounts.find(a => a.id === "pool-invalid-plan")?.quota).toMatchObject({
+      weeklyPercent: 91,
+      monthlyPercent: 33,
+    });
+  });
+
   test("GET /api/codex-auth/accounts maps go tertiary quota response to 30d display quota", async () => {
     const config = makeConfig({
       codexAccounts: [{ id: "pool-go-primary", email: "go-primary@example.test", plan: "go", isMain: false }],

tests/codex-routing.test.ts

@@ -181,6 +181,11 @@ describe("codex routing", () => {
     expect(computeCodexUsageScore({ weeklyPercent: 1 }, "go")).toBe(CODEX_UNKNOWN_USAGE_SCORE);
   });
 
+  test("usage score tolerates a non-string persisted plan", () => {
+    expect(computeCodexUsageScore({ weeklyPercent: 27, monthlyPercent: 12 }, { tier: "go" })).toBe(27);
+    expect(computeCodexUsageScore({ weeklyPercent: 27, monthlyPercent: 12 }, 1)).toBe(27);
+  });
+
   test("usage score treats unknown quota conservatively", () => {
     expect(computeCodexUsageScore(null)).toBe(CODEX_UNKNOWN_USAGE_SCORE);
     expect(computeCodexUsageScore({})).toBe(CODEX_UNKNOWN_USAGE_SCORE);