[WRONG BRANCH] fix(dashboard): safely group prototype-named providers - #231
Closed
luvs01 wants to merge 1 commit into
Closed
[WRONG BRANCH] fix(dashboard): safely group prototype-named providers#231luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds an exported ChangesDashboard model grouping
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
provider, which crashes when a provider name is an Object-prototype property (e.g.__proto__,constructor,toString).Description
Map-based helpergroupDashboardModelsand use it fromuseDashboardDataso arbitrary provider names cannot collide withObject.prototype.gui/tests/dashboard-model-grouping.test.tsthat verifies grouping works for__proto__,constructor, andtoString, including multiple models under the same provider.Testing
cd gui && bun test tests/dashboard-model-grouping.test.ts, and the new test passed.cd gui && bun test tests; the new regression passed but the environment reported unrelated pre-existing test issues (9 fake-timer failures and onenode:zlibexport error) that are not caused by this change.cd gui && bun run lintandcd gui && bun run build, both of which completed (build emitted a large-chunk advisory from Vite only), and ranbun run typecheckwhich completed successfully.Codex Task
Summary by CodeRabbit
Bug Fixes
Tests