[WRONG BRANCH] Align vision sidecar runtime default to gpt-5.6-luna - #233
[WRONG BRANCH] Align vision sidecar runtime default to gpt-5.6-luna#233luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
📝 WalkthroughWalkthroughThe OpenAI vision default model changes from ChangesVision default model
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d2f0f4d07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Motivation
gpt-5.6-lunaas the vision sidecar default while the runtime still fell back togpt-5.4-mini, causing an operator-visible mismatch whenvisionSidecar.modelwas unset.Description
gpt-5.4-minitogpt-5.6-lunaby updatingDEFAULT_VISION_MODELinsrc/vision/index.ts.gpt-5.6-lunaintests/claude-sidecar-override.test.ts.structure/04_transports-and-sidecars.mdto document the corrected OpenAI vision default.Testing
node_modules/@oven/bun-linux-x64-baseline/bin/bun test tests/claude-sidecar-override.test.ts, which passed.node_modules/@oven/bun-linux-x64-baseline/bin/bun run typecheck(bun x tsc --noEmit), which passed.bun run test; it encountered unrelated environment-sensitive failures intests/cli-help.test.tsand network-dependent discovery tests, so the full run was not used to gate this focused fix.Codex Task
Summary by CodeRabbit
New Features
gpt-5.6-lunafor improved vision processing.Documentation
Tests