Skip to content

[WRONG BRANCH] fix(mimo): honor request cancellation and header timeouts for MiMo Free adapter - #237

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-mimo-free-adapter-issues
Closed

[WRONG BRANCH] fix(mimo): honor request cancellation and header timeouts for MiMo Free adapter#237
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-mimo-free-adapter-issues

Conversation

@luvs01

@luvs01 luvs01 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The MiMo Free adapter performed raw fetch() calls without honoring the server-provided abortSignal and timeoutMs, and it performed JWT bootstrapping with no caller-aware cancellation, risking leaked upstream requests and hung sockets.

Description

  • Propagate the upstream abortSignal into adapter request builds by adding abortSignal: upstream.signal when calling buildRequest in src/server/responses/core.ts.
  • Update the MiMo adapter at src/adapters/mimo-free.ts to propagate caller cancellation into JWT bootstrapping by calling getMimoJwt(incoming.abortSignal) and to use the runtime's deadline-aware fetch helper via fetchWithAttemptDeadline for the initial and retry chat requests so timeoutMs and abortSignal are honored.
  • Add focused regression tests in tests/mimo-free-provider.test.ts that verify header-timeout behavior, caller cancellation propagation for chat fetches, and that JWT bootstrap receives the caller's abort signal.
  • Import fetchWithAttemptDeadline and wire the new signal/timeout usage; keep existing retry semantics (one re-bootstrap on 401) and system-marker injection unchanged.

Testing

  • Ran bun test tests/mimo-free-provider.test.ts and all tests in that file passed (25 passed, 0 failed).
  • Ran bun run typecheck and bun run privacy:scan, both succeeded.
  • Ran repository tests (bun run test) to exercise surrounding areas; the run progressed but hit an unrelated 60s timeout in tests/management-provider-validation.test.ts (no failures related to the MiMo changes).
  • Verified git diff --check showed no whitespace or checker errors after the edits.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a096f156-d395-4416-a198-3d5643b161bd

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and 81bf1e7.

📒 Files selected for processing (3)
  • src/adapters/mimo-free.ts
  • src/server/responses/core.ts
  • tests/mimo-free-provider.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(mimo): honor request cancellation and header timeouts for MiMo Free adapter [WRONG BRANCH] fix(mimo): honor request cancellation and header timeouts for MiMo Free adapter Aug 10, 2026
@github-actions
github-actions Bot marked this pull request as draft August 10, 2026 02:12

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81bf1e7e20

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/adapters/mimo-free.ts
@luvs01 luvs01 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant