[WRONG BRANCH] fix(mimo): honor request cancellation and header timeouts for MiMo Free adapter - #237
[WRONG BRANCH] fix(mimo): honor request cancellation and header timeouts for MiMo Free adapter#237luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81bf1e7e20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Motivation
fetch()calls without honoring the server-providedabortSignalandtimeoutMs, and it performed JWT bootstrapping with no caller-aware cancellation, risking leaked upstream requests and hung sockets.Description
abortSignalinto adapter request builds by addingabortSignal: upstream.signalwhen callingbuildRequestinsrc/server/responses/core.ts.src/adapters/mimo-free.tsto propagate caller cancellation into JWT bootstrapping by callinggetMimoJwt(incoming.abortSignal)and to use the runtime's deadline-aware fetch helper viafetchWithAttemptDeadlinefor the initial and retry chat requests sotimeoutMsandabortSignalare honored.tests/mimo-free-provider.test.tsthat verify header-timeout behavior, caller cancellation propagation for chat fetches, and that JWT bootstrap receives the caller's abort signal.fetchWithAttemptDeadlineand wire the new signal/timeout usage; keep existing retry semantics (one re-bootstrap on 401) and system-marker injection unchanged.Testing
bun test tests/mimo-free-provider.test.tsand all tests in that file passed (25passed,0failed).bun run typecheckandbun run privacy:scan, both succeeded.bun run test) to exercise surrounding areas; the run progressed but hit an unrelated 60s timeout intests/management-provider-validation.test.ts(no failures related to the MiMo changes).git diff --checkshowed no whitespace or checker errors after the edits.Codex Task