[WRONG BRANCH] fix(claude): preserve escaped v1 aliases - #238
Conversation
|
✅ Deterministic PR hygiene checks passed. |
📝 WalkthroughWalkthroughAlias decoding now expands ChangesAlias decoding
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35e34c5a60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Motivation
Description
resolveAliasinsrc/claude/alias.tsso v1 aliases now expand historical~s/~tescapes (using the existing escape decoder) and v2 remains the canonical write form for model ids that need escaping./or~(aliases now mint underclaude-ocx2-...) while ensuring v1 inputs that contain the legacy escape sequences continue to decode to their original routed model.tests/claude-alias.test.tsto add/adjust regression assertions that validate v1 compatibility decoding and v2 round-trips for slash/tilde models.docs-site/src/content/docs/.../claude-code.mdto reflect that v1 decoding remains supported for historical escaped aliases and that new escaped aliases are issued under v2.Testing
bun run typecheckand the full test suite viabun run test, and the full suite passed with the updated behavior.tests/claude-alias.test.tsas part of the suite; assertions for both v1 compatibility and v2 escaping passed.bun run privacy:scanwhich passed.cd docs-site && bun install --frozen-lockfile && bun run buildbut the documentation install/build could not complete in this environment due to external registry 403 errors, so the site build was not executed here.Codex Task
Summary by CodeRabbit
Bug Fixes
Documentation