[WRONG BRANCH] fix(claude): restore legacy v1 bare-tilde → slash alias decoding - #239
[WRONG BRANCH] fix(claude): restore legacy v1 bare-tilde → slash alias decoding#239luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1eb1328cf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Motivation
~as a stand-in for/, breaking routing for persisted aliases. This restores compatibility for those persisted aliases.Description
src/claude/alias.tsso v1 (claude-ocx-) decoding maps every bare~back to/instead of treating only~s/~tas escapes, keeping v2 (claude-ocx2-) escape semantics unchanged.resolveAliastreats v1 and v2 distinctly (v2 still expands~s/~t, v1 performs legacy~→/).tests/claude-alias.test.tsto cover legacy v1 cases (including OpenRouter-shaped aliases and cases where a legacy~was followed bysort) and to codify the intended behavior.docs-site/.../claude-code.md) to describe that legacy v1 aliases decode every bare~as/and that v2 uses explicit~s/~tescapes.Testing
bun test tests/claude-alias.test.ts— all tests in that file passed (14 passed).bun run typecheck— succeeded.bun run privacy:scan— succeeded.bun run teststarted under the pinned runner but did not complete within this environment due to concurrent test runner activity, and the docs build could not complete because dependency installation failed with remote registry HTTP 403 errors; these environment issues did not affect the focused fixes or the updated alias tests.Codex Task