Skip to content

[WRONG BRANCH] fix(claude): restore legacy v1 bare-tilde → slash alias decoding - #239

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-legacy-claude-alias-compatibility-issue
Closed

[WRONG BRANCH] fix(claude): restore legacy v1 bare-tilde → slash alias decoding#239
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-legacy-claude-alias-compatibility-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A recent change made v1 Claude aliases decode literally, but the historical v1 encoder used bare ~ as a stand-in for /, breaking routing for persisted aliases. This restores compatibility for those persisted aliases.

Description

  • Update src/claude/alias.ts so v1 (claude-ocx-) decoding maps every bare ~ back to / instead of treating only ~s/~t as escapes, keeping v2 (claude-ocx2-) escape semantics unchanged.
  • Add clarifying comments for the v1/v2 semantics and ensure resolveAlias treats v1 and v2 distinctly (v2 still expands ~s/~t, v1 performs legacy ~/).
  • Adjust tests/claude-alias.test.ts to cover legacy v1 cases (including OpenRouter-shaped aliases and cases where a legacy ~ was followed by s or t) and to codify the intended behavior.
  • Update English and Korean docs (docs-site/.../claude-code.md) to describe that legacy v1 aliases decode every bare ~ as / and that v2 uses explicit ~s/~t escapes.

Testing

  • Ran focused unit tests: bun test tests/claude-alias.test.ts — all tests in that file passed (14 passed).
  • Ran typecheck: bun run typecheck — succeeded.
  • Ran repository privacy scan: bun run privacy:scan — succeeded.
  • Attempted full test run and docs build: the full bun run test started under the pinned runner but did not complete within this environment due to concurrent test runner activity, and the docs build could not complete because dependency installation failed with remote registry HTTP 403 errors; these environment issues did not affect the focused fixes or the updated alias tests.

Codex Task

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 13dd8101-9c3f-4642-93be-d49aaa1e293c

📥 Commits

Reviewing files that changed from the base of the PR and between 121f1ad and 1eb1328.

📒 Files selected for processing (4)
  • docs-site/src/content/docs/guides/claude-code.md
  • docs-site/src/content/docs/ko/guides/claude-code.md
  • src/claude/alias.ts
  • tests/claude-alias.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 10, 2026
@github-actions github-actions Bot changed the title fix(claude): restore legacy v1 bare-tilde → slash alias decoding [WRONG BRANCH] fix(claude): restore legacy v1 bare-tilde → slash alias decoding Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 10, 2026 03:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1eb1328cf8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/claude/alias.ts
Comment thread docs-site/src/content/docs/guides/claude-code.md
@luvs01 luvs01 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant