[WRONG BRANCH] fix(lab): redact bare connect-to failure destinations - #248
[WRONG BRANCH] fix(lab): redact bare connect-to failure destinations#248luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Warning Review limit reached
Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c01625daa6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ? tail.match(/^([A-Za-z][A-Za-z0-9]{0,254})\s+(?:failed|refused|unreachable|reset|timed\s+out)\b/i) | ||
| : null; | ||
| if (failedConnectTarget?.[1]) { | ||
| return m.replace(failedConnectTarget[1], "[host]"); |
There was a problem hiding this comment.
Replace the destination occurrence within the captured tail
For a valid bare destination whose label also occurs earlier in the marker—for example, connect to connect failed or connect to con failed—String.replace rewrites the first occurrence in all of m, producing output such as [host] to connect failed and leaving the actual destination in the durable Lab text. Replace at the captured tail's offset, and add a repeated-label regression case, so the destination occurrence itself is always redacted.
Useful? React with 👍 / 👎.
Motivation
connect tosuch that bare single-label destinations likeconnect to gateway failedcould be stored unredacted.Description
src/lab/artifacts/sanitize.tsto detect when aconnect to/connecting tomarker is immediately followed by a failure term (e.g.failed,timed out,refused) and redact the bare target token as[host]while leaving ordinary connective prose intact.tests/lab-evidence-sanitization.test.tsto assert thatconnect to gateway failedandconnecting to redis timed outare redacted, whileUnable to connect to your accountand other prose remain unchanged.structure/09_compatibility-lab.mdto document the adjusted behavior in the Known limits section and describe the refinedconnect tohandling.fix(lab): redact bare connect-to failure destinations.Testing
bun run typecheckcompleted successfully.bun run privacy:scancompleted successfully.git diff --checkproduced no problems.OCX_TEST_NO_QUEUE=1 bun run test -- tests/lab-evidence-sanitization.test.tspassed, including the new regression cases verifying connect-to failure redaction and prose preservation.bun run test(full suite) was run and progressed, but reported two failing tests unrelated to the sanitizer changes (live-result trusted-receipt assertions and a root-ownedEACCESassertion that is environment-specific), so the full-suite run did not finish green in this environment.Codex Task