fix: rename artifactId from java-packageable-base, docs cleanup - #40
Conversation
Fresh-eyes review, same process applied to sage-instructor,
three-axes-framework, lux-solari-plugins, and claude-trip-computer.
pom.xml's artifactId was still literally "java-packageable-base" --
the name of a different template repo this one was bootstrapped
from -- referenced consistently (if consistently wrong) across
pom.xml, README.md, CLAUDE.md, docs/DEVELOPER_GUIDE.md, and
.github/copilot-instructions.md. Renamed to "console-jack" everywhere.
The packaging profiles (windows/mac/linux) all reference
${project.build.finalName}, so this was a safe, single-point change
that propagates correctly to the jpackage build outputs.
Also fixed:
- <repository-url> placeholder never filled in, in README's clone
instructions.
- Root README linked to a nonexistent docs/CLAUDE.md -- CLAUDE.md
lives at repo root; pointed to docs/README.md's index instead,
which already links it correctly.
- docs/README.md's own documentation index was missing 5 of the 13
files actually in that folder (AUDIO_SYSTEM_GUIDE, ECS_GUIDE,
INPUT_SYSTEM_GUIDE, RENDERING_GUIDE, STATE_MACHINE_GUIDE) -- added
over time, never indexed.
- Added a license badge to README.
GitHub topics added separately for discoverability.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ReviewThis PR is a low-risk, mechanical cleanup: renaming the Maven
Finding
Everything else in the diff looks correct and consistent with the PR description; no bugs, security, or performance concerns given this is a docs/build-config-only change. 🤖 Generated with Claude Code |
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Summary
Fresh-eyes review, same process applied to sage-instructor, three-axes-framework, lux-solari-plugins, and claude-trip-computer.
pom.xml's artifactId was still literallyjava-packageable-base-- the name of a different template repo this one was bootstrapped from -- referenced consistently (if consistently wrong) acrosspom.xml,README.md,CLAUDE.md,docs/DEVELOPER_GUIDE.md, and.github/copilot-instructions.md. Renamed toconsole-jackeverywhere. The packaging profiles (windows/mac/linux) all reference${project.build.finalName}, so this is a safe, single-point change.Also fixed:
<repository-url>placeholder never filled in.docs/CLAUDE.md-- pointed todocs/README.md's index instead.docs/README.md's own doc index was missing 5 of 13 files in that folder.GitHub topics added separately.
Test plan
pom.xmlvalidated as well-formed XMLmaven.yml) will build the project on this PR since it triggers ondevelopjava-packageable-baseremain anywhere in the repo🤖 Generated with Claude Code