Skip to content

Allow the user to set the ctags binary#42

Open
vicentebolea wants to merge 2 commits into
lvc:masterfrom
vicentebolea:vicentebolea-patch-1
Open

Allow the user to set the ctags binary#42
vicentebolea wants to merge 2 commits into
lvc:masterfrom
vicentebolea:vicentebolea-patch-1

Conversation

@vicentebolea

Copy link
Copy Markdown

In some distros (e.g OpenSUSE) universal ctags is installed as universal-ctags. This change allows the user to set the binary of ctags to anything using the $CTAGS env variable.

@vicentebolea

Copy link
Copy Markdown
Author

@rurban I wonder if you could review this

@vicentebolea

Copy link
Copy Markdown
Author

@linuxhw

@rurban rurban left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong. The my declaration must be outside the block, the logic is wrong, and a typo in ENV

@rurban rurban left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is enough:

my $CTAGS = $ENV{"CTAGS"} ? $ENV{"CTAGS"} : "ctags";

Comment thread abi-dumper.pl Outdated
@vicentebolea

Copy link
Copy Markdown
Author

@rurban thanks for the review, I applied your changes. Please find it in the last push, feel free to squash merge since the orginal commit has no value.

@vicentebolea

Copy link
Copy Markdown
Author

@scutuatua-crypto merge me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants