fix: quarterly-audit stub logs honest skip warning (S6-007)#100
Merged
Conversation
During the live paper-validation run, logs are evidence: the IncomeSleeve_QuarterlyAudit TODO stub logged "Quarterly quality audit complete" while doing nothing, which would falsify the run record in the Jul 1-7 audit window. The stub now logs a single explicit Warning that it is not implemented and was skipped (deferred per backlog, S7+). No Discord send, no cron change, no audit logic added; guard and catch/rethrow stay. Also introduces the internal Func<DateTime> clock seam (Default D1) on IncomeSleeveFunction - both timer methods read the injected clock instead of DateTime.UtcNow - so the day-of-month guard is unit-testable and S6-001 can rebase on it for the first-trading-weekday gate. Tests: 5 new in IncomeSleeveFunctionTests (TDD RED on the honesty assertions first); full suite 595 passed / 0 failed. Local host-boot smoke (tools/ci/host-boot-smoke.sh, PORT=7188, throwaway Azurite) green: all 4 timers registered, no failure signatures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
IncomeSleeve_QuarterlyAuditis a stub, but it logged a misleading "complete" message. It now logs an explicit spec-mandated Warning stating the audit is skipped/not implemented. Also adds an internalFunc<DateTime>clock-seam constructor (groundwork that S6-001 will rebase on) and 5 new unit tests.Why
Validation-run logs are evidence for the 12-week paper run. A stub that logs "complete" falsifies the record — anyone auditing the logs would believe a quarterly audit ran when it did not. The Warning makes the gap visible in the log stream.
Test plan
Notes
The internal clock-seam ctor is intentional groundwork: S6-001 rebases on it.
🤖 Generated with Claude Code