Skip to content

docs(decisions): PDR-004 resolved, KD-001 closed, KD-002 re-scoped (S5-006) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lwalden merged 2 commits into from
Jun 10, 2026
Merged

docs(decisions): PDR-004 resolved, KD-001 closed, KD-002 re-scoped (S5-006) #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc61e7a
docs(decisions): PDR-004 resolved, KD-001 closed, KD-002 re-scoped (S…
lwalden Jun 10, 2026
15a07e7
fix(review): point PDR-004 settings seam at the runtime key (S5-006)
lwalden Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions DECISIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,8 @@ Start with daily batch, assess need for intraday monitoring (especially near-exp
**Blocking:** Nothing (independent) | **Needs:** Options sleeve proven in live trading
Potential future addition after options sleeve is validated.

### PDR-004: Sleeve-Level Validation Thresholds for Live Activation
**Blocking:** Final go-live recommendation logic | **Needs:** Numeric pass/fail criteria by sleeve
Define exact per-sleeve thresholds (return/risk/consistency metrics) that qualify a sleeve for live activation.
### PDR-004: ~~Sleeve-Level Validation Thresholds for Live Activation~~ RESOLVED
**Resolution:** Resolved in code by S4-001 (PR #81), owner-confirmed 2026-06-09 — per-sleeve paper gate: hit rate ≥45%, profit factor ≥1.3, max drawdown ≤15%, ≥12 weeks observed, profitable-OR-beat-SPY (strict >), $100k minimum live capital per sleeve. Values of record in `src/TradingSystem.Core/Configuration/SleeveValidationThresholds.cs`; evaluation-only via the `IConfigRepository` settings seam (key `"sleeveValidationThresholds"`), never on any order/execution path; consumed by the S4-002 scorecard. PDR-005 (live sleeve set/capital split) remains pending.

### PDR-005: Initial Live Sleeve Set and Capital Split
**Blocking:** Live transition execution plan | **Needs:** Paper validation outputs + owner decision
Expand Down Expand Up @@ -343,8 +342,8 @@ Select which sleeve(s) activate first and final initial capital split/account ma

| ID | Description | Impact | Logged |
|---|---|---|---|
| KD-001 | Discord webhook not configured | Stop alerts silently drop | 2026-02-16 |
| KD-002 | Claude API key not provisioned | Regime service integration blocked | 2026-02-16 |
| KD-001 | ✅ RESOLVED by S5-004 day-0 wiring (2026-06-10). ~~Discord webhook not configured~~ — webhook provisioned from Bitwarden "ClimbOn Co" into gitignored `local.settings.json`; test alert delivered (HTTP 204) through the production guard path (see `docs/paper-validation-runbook.md` Run Log) | Stop alerts silently drop — closed | 2026-02-16 |
| KD-002 | Claude API key not provisioned — NOT required under default posture: ADR-029/030 gateway-or-rules with `DirectApiFallbackEnabled=false` means zero metered spend (gateway bearer key provisioned via S5-004). Becomes relevant only if the owner explicitly enables the metered fallback | Conditional — regime integration shipped, degrades to deterministic rules | 2026-02-16 |
| KD-003 | Backtest pipeline paths use Python (not .NET) | Must install Python + deps separately for backtesting | 2026-04-07 |
| KD-004 | ✅ RESOLVED 2026-05-29 (S3-001, PR #70). ~~CachingMarketDataService.cs ~360 lines, exceeds 300-line architecture-fitness threshold (grew across S2-001/003/005/006)~~ — decomposed into a 125-line facade + new 280-line MarketRegimeProvider (internal composition, no DI change, zero behavior change) per ADR-017 | Maintainability — closed | 2026-05-29 |

Expand Down